[Kde-pim] Review Request: folder properties: do not create a job on the stack

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107521/
-----------------------------------------------------------

(Updated Nov. 30, 2012, 8:36 a.m.)


Review request for KDEPIM.


Changes
-------

Use an additional slot to run the fetch job asynchronously (avoids a nested event loop).


Description
-------

While reviewing https://git.reviewboard.kde.org/r/107341/, Kevin Krammer observed that a job was being created on the stack (by already existing code).  Since jobs auto-delete themselves by default, this is incorrect and could lead to a crash as a result of a double deletion.

This change creates the job on the heap instead, allowing it to delete itself when appropriate.


Diffs (updated)
-----

  kmail/kmmainwidget.h 5eefaa7 
  kmail/kmmainwidget.cpp 5568b9a 

Diff: http://git.reviewboard.kde.org/r/107521/diff/


Testing
-------

Built kdepim with this change, checked operation of "Folder Properties" dialogue for both local and IMAP folders.


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/