[Kde-pim] Review Request: Only increase instance counter if instance was successfully created

Lamarque Vieira Souza lamarque at kde.org
Fri Mar 16 22:25:46 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104309/
-----------------------------------------------------------

Review request for Akonadi.


Description
-------

Akonadi increases agent's instance counter even when it fails to create the instance. When akonadi exists it saves the instance number and on next startup it creates that same number of instances, which tends to increase everytime time akonadi fails to start an instance.

I think we should add a limit to the number of instances akonadi can create.


This addresses bug 278332.
    http://bugs.kde.org/show_bug.cgi?id=278332


Diffs
-----

  server/control/agentmanager.cpp 4579cd5 

Diff: http://git.reviewboard.kde.org/r/104309/diff/


Testing
-------

No test done, but it seems logical not to increase the instance counter when the instance is not created.


Thanks,

Lamarque Vieira Souza

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list