[Kde-pim] Review Request: Only increase instance counter if instance was successfully created

[Lamarque Vieira Souza]

> On March 17, 2012, 9:12 a.m., Volker Krause wrote:
> > Sorry, but this patch has absolutely nothing to do with bug 278332. The instance counter you are changing here is only used to generate unique identifiers for agent instances, it does not control how many instances exist. So, the only thing this change does is introduce the risk of possible identifier duplication in some error scenarios.
> > 
> > The correct solution for this bug is probably in kdepimlibs commit a9da6ca4d9823b39a81302cb1253339a3066157f (which fixes the cause but does not clean up the damage).

Ok then. Anyway, wouldn't be more prudent to limit the number of instances or at least make them close theirselves after a timeout like kio_* do? Sure there must always be at least one instance of each agent type running.

Thanks for the info that the problem has been fixed.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104309/#review11499
-----------------------------------------------------------


On March 16, 2012, 10:25 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104309/
> -----------------------------------------------------------
> 
> (Updated March 16, 2012, 10:25 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> Akonadi increases agent's instance counter even when it fails to create the instance. When akonadi exists it saves the instance number and on next startup it creates that same number of instances, which tends to increase everytime time akonadi fails to start an instance.
> 
> I think we should add a limit to the number of instances akonadi can create.
> 
> 
> This addresses bug 278332.
>     http://bugs.kde.org/show_bug.cgi?id=278332
> 
> 
> Diffs
> -----
> 
>   server/control/agentmanager.cpp 4579cd5 
> 
> Diff: http://git.reviewboard.kde.org/r/104309/diff/
> 
> 
> Testing
> -------
> 
> No test done, but it seems logical not to increase the instance counter when the instance is not created.
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/