[Kde-pim] Review Request: Improve contact searching, avoid nepomuk round trips.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104225/#review11285
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker Krause


On March 11, 2012, 12:54 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104225/
> -----------------------------------------------------------
> 
> (Updated March 11, 2012, 12:54 p.m.)
> 
> 
> Review request for Akonadi, Tobias Koenig, Volker Krause, and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> This does a few things to improve searching for contacts. Firstly it checks if the result of a query already contains the akonadi item id property and if so, doesn't roundtrip again to go fetch it. Normally (to the best of my nepomuk API understanding), if the query asks for a property as part of the select statement, the result should contain it. That doesn't seem to work, so this patch additionally adds an explicit request for the akonadi item id property, to make sure we actually hit the previously described optimization. If the id isn't there, we still fall back to doing the roundtrip to ask for it.
> 
> 
> Diffs
> -----
> 
>   server/src/nepomuksearch.h a596db3a202b8a56a5d42e9871d61e6c6d112a26 
>   server/src/nepomuksearch.cpp 04db3009f5725abbb7cd11ec69c433c426ee0fbd 
> 
> Diff: http://git.reviewboard.kde.org/r/104225/diff/
> 
> 
> Testing
> -------
> 
> contact search jobs with and without the id property in the select clause still work.
> 
> 
> Thanks,
> 
> Till Adam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/