[Kde-pim] Review Request: Improve contains queries.

[Ingo Klöcker]

> On March 18, 2012, 10:01 p.m., Christian Mollekopf wrote:
> > Are you sure you want to limit matching to word boundaries for address completion? One frequent usecase for me is that I only remember part of the address, or forget some prefix, so if I type "mollekopf" I'd want "cmollekopf at bla.org" to show up. Patch looks fine to me from a brief look at it.

Wouldn't address completion include the contact's name and thus find the "address" matching "mollekopf"? Anyway, IIRC, the last time we discussed address completion we concluded that arbitrary substring matching would be useful but that substring matches should have a much lower priority than word boundary matches in the list of candidates. I guess this will require two separate lookups where the second arbitrary-substring lookup would probably only be necessary if the first one does not return any matches.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104338/#review11591
-----------------------------------------------------------


On March 18, 2012, 9:07 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104338/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 9:07 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Tobias Koenig, Volker Krause, and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Improve contains queries.
> 
> If we are searching for 2 characters or less, we assume substring
> matches anywhere don't make much sense, so we use whole word matching
> via the relatively fast bif:contains. If we are looking for longer
> substrings, we can search for the substring anywhere, using a regex
> filter, or for the substring at the start of words, using a faster regex
> that limits to word boundaries. The later is useful in particul for
> address completion, which is a frequent enough special case to warrant
> optimizing it a bit.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactsearchjob.h be29fd698cd87a6318a691295e0e7b30829525f5 
>   akonadi/contact/contactsearchjob.cpp f1e3fbf68a1d2fabbd8067f804035ae07d2a55ee 
> 
> Diff: http://git.reviewboard.kde.org/r/104338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Adam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/