[Kde-pim] Review Request: Improve contains queries.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104338/#review11699
-----------------------------------------------------------

Ship it!


Looks good to me. The question Christian raised whether or not matching on word boundaries is sensible is independent of this patch I think, this actually allows us to choose was we want in the client code, so this is definitely an improvement.

- Volker Krause


On March 18, 2012, 9:07 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104338/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 9:07 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Tobias Koenig, Volker Krause, and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Improve contains queries.
> 
> If we are searching for 2 characters or less, we assume substring
> matches anywhere don't make much sense, so we use whole word matching
> via the relatively fast bif:contains. If we are looking for longer
> substrings, we can search for the substring anywhere, using a regex
> filter, or for the substring at the start of words, using a faster regex
> that limits to word boundaries. The later is useful in particul for
> address completion, which is a frequent enough special case to warrant
> optimizing it a bit.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactsearchjob.h be29fd698cd87a6318a691295e0e7b30829525f5 
>   akonadi/contact/contactsearchjob.cpp f1e3fbf68a1d2fabbd8067f804035ae07d2a55ee 
> 
> Diff: http://git.reviewboard.kde.org/r/104338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Adam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/