[Kde-pim] Review Request: Silence the filter agent failures

Szymon Stefanek pragma at kvirc.net
Thu Jan 12 00:29:12 GMT 2012 


> On Jan. 10, 2012, 7:55 p.m., Andras Mantia wrote:
> > I don't like it. Instead, I would:
> > - transform the message to a passive popup
> > - improve the error so it gives more information about what failed (e.g. message that was involved, destination folder).
> 
> Szymon Stefanek wrote:
>     Yep, I agree that more information might be a step forward.
>     At least some users would investigate the real problem instead
>     of just getting annoyed :D
>     
>     ...
>     
>     
>     However, we should also keep in mind that most users will not be
>     able to or willing to investigate... maybe a "don't show again" checkbox?
>     
>     In the current state I have to click the OK button 30-40-50 times
>     for each email check... Sometimes I even leave the box open just because
>     I just don't want to click anymore. The agent sits there and blocks
>     further processing...
>     
>     
>     What do you mean by "passive popup"? A non blocking one?
>
> 
> Andras Mantia wrote:
>     Passive popup is something that appears above the (i) icon in the panel. See KPassivePopup. It is a non-blocking popup.
> 
> Szymon Stefanek wrote:
>     Aha... 
>     Yes, that would be a good solution too.
>     
>     I'll check it out.
> 
> Milian Wolff wrote:
>     aha so I'm _not_ the only one who gets these errors? Note that I've added them, hoping that others esp. ones with less esoteric setups could reproduce it. Szymon, could you explain your setup a bit?
>     
>     I'd rather fix these errors instead of silencing the errors as they are just that - errors...

My setup is quite complex. I have several pop resources, an imap resource,
a large and complex maildir inherited from KDE3 kmail and several filters including
a spamfilter based on spamassassin...

However.. I've debugged the issue a bit.

It seems that most errors are triggered by filters that have both a modify and a move job. 

akonadi_mailfilter_agent(16793) FilterManager::processContextItem:  - starting modify payload job for item  291497 / KUrl("akonadi:?item=291497")
akonadi_mailfilter_agent(16793) FilterManager::processContextItem:  - starting modify payload job for item  291498 / KUrl("akonadi:?item=291498")
akonadi_mailfilter_agent(16793) FilterManager::processContextItem:  - starting modify payload job for item  291499 / KUrl("akonadi:?item=291499")
akonadi_mailfilter_agent(16793) FilterManager::processContextItem:  - starting modify payload job for item  291500 / KUrl("akonadi:?item=291500")
akonadi_mailfilter_agent(16793) FilterManager::processContextItem:  - starting modify payload job for item  291501 / KUrl("akonadi:?item=291501")
QFSFileEngine::open: No file name specified
Payload file  ""  could not be open for reading! 
Error:  "No file name specified" 
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult: modify job for  291497 / KUrl("akonadi:?item=291497")  terminated
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult:  - starting move job for item  291497 / KUrl("akonadi:?item=291497")  targeting collection  843 / ""
QFSFileEngine::open: No file name specified
Payload file  ""  could not be open for reading! 
Error:  "No file name specified" 
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult: modify job for  291498 / KUrl("akonadi:?item=291498")  terminated
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult:  - starting move job for item  291498 / KUrl("akonadi:?item=291498")  targeting collection  843 / ""
QFSFileEngine::open: No file name specified
Payload file  ""  could not be open for reading! 
Error:  "No file name specified" 
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult: modify job for  291499 / KUrl("akonadi:?item=291499")  terminated
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult:  - starting move job for item  291499 / KUrl("akonadi:?item=291499")  targeting collection  843 / ""
QFSFileEngine::open: No file name specified
Payload file  ""  could not be open for reading! 
Error:  "No file name specified" 
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult: modify job for  291500 / KUrl("akonadi:?item=291500")  terminated
akonadi_mailfilter_agent(16793) FilterManager::Private::modifyJobResult:  - starting move job for item  291500 / KUrl("akonadi:?item=291500")  targeting collection  843 / ""
QFSFileEngine::open: No file name specified
kmail2(14482)/libakonadi Akonadi::EntityTreeModelPrivate::monitoredItemChanged: Got a stale notification for an item which was already removed. 291497 "1325992168.R540.spyro" 
kmail2(14482)/libakonadi Akonadi::EntityTreeModelPrivate::monitoredItemChanged: Got a stale notification for an item which was already removed. 291498 "1325992168.R345.spyro" 
kmail2(14482)/libakonadi Akonadi::EntityTreeModelPrivate::monitoredItemChanged: Got a stale notification for an item which was already removed. 291499 "1325992169.R379.spyro" 
kmail2(14482)/libakonadi Akonadi::EntityTreeModelPrivate::monitoredItemChanged: Got a stale notification for an item which was already removed. 291500 "1325992169.R68.spyro" 


The filter sets context.needsPayloadStore() and the agent starts an ItemModifyJob.
The job terminates successfully and inside modifyJobResult() an ItemMoveJob is started.
That ItemMoveJob, then, terminates with the error: "No items found".

It seems that the ItemModifyJob moves the item too, but I still have to figure out where...


- Szymon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103665/#review9726
-----------------------------------------------------------


On Jan. 10, 2012, 6:05 a.m., Szymon Stefanek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103665/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 6:05 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The message boxes created by the filter agent are user-unfriendly.
> 
> The agent works in background and very often fails to move or delete
> some (many!) items. This results in unstoppable sequences of
> messages that popup in the middle of the screen and must be
> dismissed by the user... very annoying.
> 
> Can we disable the messages for now?
> 
> If the filters have to fail, let them fail silently, unless
> there is danger of data loss...
> 
> 
> Diffs
> -----
> 
>   mailfilteragent/filtermanager.cpp ae23b0c 
> 
> Diff: http://git.reviewboard.kde.org/r/103665/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> 
> Thanks,
> 
> Szymon Stefanek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list