[Kde-pim] Review Request: Do not add an organizer to appointments without attendees

[Andre Heinecke]

> On March 22, 2012, 4:31 p.m., Andre Heinecke wrote:
> > incidenceeditor-ng/incidencedefaults.cpp, line 390
> > <http://git.reviewboard.kde.org/r/104368/diff/1/?file=54278#file54278line390>
> >
> >     With that ifdef enabled the Organizer would be added as an attendee.
> >     So you no longer would have an organizer for an incidence without attendees.
> >     
> >     Please move that ifdefed part out of the !mAttendees.empty() part so that this behavior would stay unchanged.
> 
> Stephan Diestelhorst wrote:
>     I was not sure what the logic is, here.   You always want to add the organizer as an attendee, even if there are no attendees present?  If so, then it should also get added as an organizer, since there is an attendant?
>     
>     What is that ENTERPRISE_BUILD used for?

Thanks for updating your patch, and yes always adding the organizer as an attendee is wanted.

ENTERPRISE_BUILD comes from merging Enterprise developments of Kdepim that were developed for a customer into upstream sources. Since sometimes the whishes of a customer (like in this case) differ from what makes sense or from what the rest of the community wants. So there is a build Option to change some behavior in case of disagreements. 

>From my point of view there are no more concerns with your Patch now, thanks.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104368/#review11757
-----------------------------------------------------------


On April 2, 2012, 4:01 p.m., Stephan Diestelhorst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104368/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 4:01 p.m.)
> 
> 
> Review request for KDEPIM and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> Do not add an organizer to an appointment if there are no attendees present.  Fixed in those locations where it was actually triggered for an appointment that did not have any attendees.  Makes the resulting appointmes editale in Google Calendar and on Android phones.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/incidenceattendee.cpp 00a86e05507edc86999671eca4f94bbc5d1d07ec 
>   incidenceeditor-ng/incidencedefaults.cpp 36f67c9b824b38ea50058c9a7ea2d0879a972178 
> 
> Diff: http://git.reviewboard.kde.org/r/104368/diff/
> 
> 
> Testing
> -------
> 
> Created several appointments to check that they become editable.  Modified appointments on both phone and KOrganizer and checked they would update on the other respective end.
> 
> 
> Thanks,
> 
> Stephan Diestelhorst
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/