[Kde-pim] Review Request: Move akonadi-google resources to KDE PIM

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104775/#review13073
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/104775/#comment10168>

    Remove the 'REQUIRED' keyword



resources/google/calendar/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104775/#comment10179>

    Not needed. The macro is defined in the main CMakeLists.txt



resources/google/calendar/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104775/#comment10178>

    Not needed



resources/google/calendar/calendarresource.h
<http://git.reviewboard.kde.org/r/104775/#comment10177>

    Remove KDE/



resources/google/calendar/calendarresource.cpp
<http://git.reviewboard.kde.org/r/104775/#comment10176>

    Remove KDE/



resources/google/calendar/defaultreminderattribute.h
<http://git.reviewboard.kde.org/r/104775/#comment10175>

    Remove KDE/



resources/google/calendar/resource_events.cpp
<http://git.reviewboard.kde.org/r/104775/#comment10174>

    Remove KDE/



resources/google/calendar/resource_tasks.cpp
<http://git.reviewboard.kde.org/r/104775/#comment10173>

    Remove KDE/



resources/google/calendar/settingsdialog.h
<http://git.reviewboard.kde.org/r/104775/#comment10172>

    Remove KDE/



resources/google/contacts/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104775/#comment10171>

    Not needed (this macro is already defined in the main CMakeLists.txt)



resources/google/contacts/contactsresource.h
<http://git.reviewboard.kde.org/r/104775/#comment10170>

    Remove KDE/



resources/google/contacts/contactsresource.cpp
<http://git.reviewboard.kde.org/r/104775/#comment10169>

    Remove KDE/


- Christophe Giboudeaux


On April 29, 2012, 12:24 a.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104775/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 12:24 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Move the Akonadi resources for Google to kdepim-runtime/resources/google/. The libkgoogle is set as an optional compile-time dependency.
> 
> Source code of the resources is based on recent akonadi-google 0.3.1 release, I just updated the coding style (hopefully correctly) and removed some backward-compatibility code (support for KCal and a workaround for a bug in older versions of KOrganizer).
> 
> libkgoogle is atm available only from the akonadi-google repository; request for libkgoogle repository in extragear has already been submitted.
> 
> 
> Diffs
> -----
> 
>   resources/google/CMakeLists.txt PRE-CREATION 
>   resources/google/calendar/CMakeLists.txt PRE-CREATION 
>   resources/CMakeLists.txt 6fd0605 
>   CMakeLists.txt 342dbb1 
>   resources/google/calendar/calendareditor.h PRE-CREATION 
>   resources/google/calendar/calendareditor.cpp PRE-CREATION 
>   resources/google/calendar/calendarresource.h PRE-CREATION 
>   resources/google/calendar/calendarresource.cpp PRE-CREATION 
>   resources/google/calendar/defaultreminderattribute.h PRE-CREATION 
>   resources/google/calendar/defaultreminderattribute.cpp PRE-CREATION 
>   resources/google/calendar/googlecalendarresource.desktop PRE-CREATION 
>   resources/google/calendar/resource_events.cpp PRE-CREATION 
>   resources/google/calendar/resource_tasks.cpp PRE-CREATION 
>   resources/google/calendar/settings.h PRE-CREATION 
>   resources/google/calendar/settings.cpp PRE-CREATION 
>   resources/google/calendar/settingsbase.kcfg PRE-CREATION 
>   resources/google/calendar/settingsbase.kcfgc PRE-CREATION 
>   resources/google/calendar/settingsdialog.h PRE-CREATION 
>   resources/google/calendar/settingsdialog.cpp PRE-CREATION 
>   resources/google/calendar/tasklisteditor.h PRE-CREATION 
>   resources/google/calendar/tasklisteditor.cpp PRE-CREATION 
>   resources/google/calendar/ui/calendar_editor.ui PRE-CREATION 
>   resources/google/calendar/ui/settingsdialog.ui PRE-CREATION 
>   resources/google/calendar/ui/tasklist_editor.ui PRE-CREATION 
>   resources/google/contacts/CMakeLists.txt PRE-CREATION 
>   resources/google/contacts/contactsresource.h PRE-CREATION 
>   resources/google/contacts/contactsresource.cpp PRE-CREATION 
>   resources/google/contacts/googlecontactsresource.desktop PRE-CREATION 
>   resources/google/contacts/settings.h PRE-CREATION 
>   resources/google/contacts/settings.cpp PRE-CREATION 
>   resources/google/contacts/settingsbase.kcfg PRE-CREATION 
>   resources/google/contacts/settingsbase.kcfgc PRE-CREATION 
>   resources/google/contacts/settingsdialog.h PRE-CREATION 
>   resources/google/contacts/settingsdialog.cpp PRE-CREATION 
>   resources/google/contacts/ui/groupeditor.ui PRE-CREATION 
>   resources/google/contacts/ui/settingsdialog.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104775/diff/
> 
> 
> Testing
> -------
> 
> No data loss bugs, all reported crashes were fixed in 0.3.1.
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/