[Kde-pim] Review Request: Summary: Reduce the issues found by krazy2, directory: contacts

[Guy Maurel]

> On April 19, 2012, 4:20 p.m., Kevin Krammer wrote:
> > resources/contacts/contactsresource.cpp, line 403
> > <http://git.reviewboard.kde.org/r/104669/diff/1/?file=58064#file58064line403>
> >
> >     Not wrong, but what's the reason for this change?

krazy2 says it is not english! I make a call to Allen Winter


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104669/#review12659
-----------------------------------------------------------


On April 19, 2012, 4:17 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104669/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 4:17 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Taking a look to
>   http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdepim-runtime/resources/index.html
> 
> one can see: kdepim-runtime as still more than 600 issues.
> 
> I propose to reduce this with this bugfix. 
> Thanks to Kevin for the very usefull hints of tippos such as:
> old: if(condition){
> new: if ( condition ) {
> 
> 
> Diffs
> -----
> 
>   resources/contacts/contactsresource.cpp 547e9c9 
> 
> Diff: http://git.reviewboard.kde.org/r/104669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/