[Kde-pim] Review Request: KMail encountered a fatal error

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104477/#review12677
-----------------------------------------------------------



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment9931>

    I think we also need to check how the directory looks like.
    The resource supports two modes: one where the top level directory can contain mails and one where it can only contain folders.
    Should be possible to use the Maildir API to check which one applies



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/104477/#comment9932>

    in this case it would probably be a good idea to set the resource into container mode for its top level


- Kevin Krammer


On April 7, 2012, 5:28 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104477/
> -----------------------------------------------------------
> 
> (Updated April 7, 2012, 5:28 p.m.)
> 
> 
> Review request for KDEPIM, Tobias Koenig, Volker Krause, and Kevin Krammer.
> 
> 
> Description
> -------
> 
> All the bugs get the Message: "KMail encountered a fatal error"
> This is now fixed.
> 
> This happens:
> - some situations with kmail1 and early kmail2 where a configuration file wasn't store properly.
> - the user deletes or looses a configuration file.
> 
> The first case was fixed by Tobias 2012-02-12.
> For the second case, kmail2 has now a procedure to repair the configuration.
> 
> In fact, the bug doesn't occur at kmail2 but at akonadi_agent_launcher as a resource wll be build, even if the configuration file 
> (such as "akonadi_maildir_resource_0rc") is missing.
> This will be now detected and repaired.
> Thanks to Kevin for choaching.
> 
> 
> This addresses bugs 124111, 218278, 246027, 250747, 258927, 259355, 259355, 277530, 284748, 286264, 286652, 290159, and 292384.
>     http://bugs.kde.org/show_bug.cgi?id=124111
>     http://bugs.kde.org/show_bug.cgi?id=218278
>     http://bugs.kde.org/show_bug.cgi?id=246027
>     http://bugs.kde.org/show_bug.cgi?id=250747
>     http://bugs.kde.org/show_bug.cgi?id=258927
>     http://bugs.kde.org/show_bug.cgi?id=259355
>     http://bugs.kde.org/show_bug.cgi?id=259355
>     http://bugs.kde.org/show_bug.cgi?id=277530
>     http://bugs.kde.org/show_bug.cgi?id=284748
>     http://bugs.kde.org/show_bug.cgi?id=286264
>     http://bugs.kde.org/show_bug.cgi?id=286652
>     http://bugs.kde.org/show_bug.cgi?id=290159
>     http://bugs.kde.org/show_bug.cgi?id=292384
> 
> 
> Diffs
> -----
> 
>   resources/maildir/maildirresource.h 41f35b5 
>   resources/maildir/maildirresource.cpp e8134fb 
> 
> Diff: http://git.reviewboard.kde.org/r/104477/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/