[Kde-pim] Review Request: Fix for kdepimlibs compilation failures related to wrong argument passing of QByteArray

[Romário Rios]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102433/
-----------------------------------------------------------

(Updated Sept. 12, 2011, 5:36 p.m.)


Review request for KDEPIM.


Summary
-------

A lot of compilation erros like this one[http://paste.kde.org/114253 ] emerged when I tried to compile latest kdepimlibs master using latest Qt master. All of them happen when operator+ (or operator?) is used with a QByteArray as the argument of a function (making it return a bytearray stringbuilder), while the argument should be a const char * or a QString. This patch fixes them, making kdepimlibs compile.

EDIT: I contacted the trolls on this, as I got the same errors in many other modules, and this is probably due to me using Qt master, which is deprecated. Closing the request, then.


Diffs
-----

  akonadi/contact/contactgroupsearchjob.cpp b845b61 
  akonadi/contact/contactsearchjob.cpp 1dfe4d2 
  akonadi/protocolhelper.cpp 187c74f 
  kcal/icalformat_p.cpp 1685337 
  kcalcore/icalformat_p.cpp 5938d02 
  kcalutils/incidenceformatter.cpp 65bf74c 
  kioslave/imap4/imap4.cpp 9b33d71 
  kioslave/imap4/mimeheader.cpp 6bb6586 
  kontactinterface/plugin.cpp 2b187f3 
  kxmlrpcclient/query.cpp bcab7ea 

Diff: http://git.reviewboard.kde.org/r/102433/diff


Testing
-------

It compiles. And probably nothing changes in the behavior of the module, as I just made type conversions.


Thanks,

Romário

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/