[Kde-pim] Review Request: Add isConfiguring method to AgentBase to easily limit to one configuration dialog per agent.

[Kevin Krammer]

On Tuesday, 2011-09-13, Martin Bednár wrote:
> Le Mardi 13 de septembre 2011 10:14:55 Kevin Krammer a écrit :

> > I wonder whether it would not be easier to just check this internally,
> > e.g. not call configure() if it has already been called and not
> > returned.
> 
> internally? not sure what you mean here, in each agent or in
> AgentBasePrivate? Each agent implementing its own check? That's what I
> wanted to avoid :)

Right, I meant somewhere in the library code, e.g. agentbase, 
agentbaseprivate, whereever.

> If you mean in AgentBasePrivate, then I haven't found a
> way to check if a reimplemented configure() has been called...

configure() has to be called from somewhere, independent of whether it has 
been reimplemented or not.

> As I mentioned in the review request, I tried to find the way to implement
> it with the least work for agents, and came up with this. If you tell me
> it's the wrong way, I'll do it directly in the agent/ressource.

No, I agree bothering each individual agent/resource developer would be less 
desirable.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110913/9dc1f3f9/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/