[Kde-pim] Review Request: Add isConfiguring method to AgentBase to easily limit to one configuration dialog per agent.

[Martin Bednár]

Le Mardi 13 de septembre 2011 10:14:55 Kevin Krammer a écrit :
> On Tuesday, 2011-09-13, Kevin Krammer wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/102594/#review6464
> > -----------------------------------------------------------
> > 
> > 
> > 
> > akonadi/agentbase.h
> > <http://git.reviewboard.kde.org/r/102594/#comment5728>
> > 
> >     This is not possible.
> >     Adding a virtual method is not a binary compatible change
> >     (virtual
> > 
> > method table changes size) and thus not allowed in public API by KDE's
> > library policies
> 
> As a reference:
> http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++

thanks, will try to understand it.
> 
> I wonder whether it would not be easier to just check this internally, e.g.
> not call configure() if it has already been called and not returned.

internally? not sure what you mean here, in each agent or in AgentBasePrivate?
Each agent implementing its own check? That's what I wanted to avoid :)
If you mean in AgentBasePrivate, then I haven't found a way to check if a 
reimplemented configure() has been called...
As I mentioned in the review request, I tried to find the way to implement it 
with the least work for agents, and came up with this. If you tell me it's the 
wrong way, I'll do it directly in the agent/ressource.

Thanks for bearing with my experiments :)

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110913/695574ed/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/