[Kde-pim] Review Request: Add isConfiguring method to AgentBase to easily limit to one configuration dialog per agent.

Kevin Krammer kevin.krammer at gmx.at
Tue Sep 13 09:14:55 BST 2011


On Tuesday, 2011-09-13, Kevin Krammer wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102594/#review6464
> -----------------------------------------------------------
> 
> 
> 
> akonadi/agentbase.h
> <http://git.reviewboard.kde.org/r/102594/#comment5728>
> 
>     This is not possible.
>     Adding a virtual method is not a binary compatible change (virtual
> method table changes size) and thus not allowed in public API by KDE's
> library policies

As a reference:
http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++

I wonder whether it would not be easier to just check this internally, e.g. 
not call configure() if it has already been called and not returned.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110913/c0959564/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list