[Kde-pim] Review Request: Enable direct attaching of folders in kmail

[Laurent Montel]

> On Sept. 9, 2011, 6:50 a.m., Laurent Montel wrote:
> > For me it's ok now
> 
> Martin Bednar wrote:
>     Thanks, still don't have commit rights though :(

Ok I commited it.
Thanks a lot.
I tested it it works fine but we can't select a folder from kfiledialog so it works just when we dnd.
Perhaps we must find a method to add from kfiledialog (not time to look at today)
(but I don't want to add new KAction we must find a method with same KAction)

Thanks for this bug fix.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102501/#review6348
-----------------------------------------------------------


On Sept. 8, 2011, 5:37 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102501/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 5:37 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Creates a new class attachmentfromfolder that enables automatic compression (zip) and attachment of folders dropped on the messagecomposer window.
> 
> 
> This addresses bug 42767.
>     http://bugs.kde.org/show_bug.cgi?id=42767
> 
> 
> Diffs
> -----
> 
>   messagecomposer/attachmentcontrollerbase.cpp f8aea5c 
>   messagecore/CMakeLists.txt 821625f 
>   messagecore/attachmentfromfolderjob.h PRE-CREATION 
>   messagecore/attachmentfromfolderjob.cpp PRE-CREATION 
>   messagecore/attachmentfromurlbasejob.h PRE-CREATION 
>   messagecore/attachmentfromurlbasejob.cpp PRE-CREATION 
>   messagecore/attachmentfromurljob.h c509114 
>   messagecore/attachmentfromurljob.cpp 615218a 
> 
> Diff: http://git.reviewboard.kde.org/r/102501/diff
> 
> 
> Testing
> -------
> 
> Sent myself an email with a dropped folder attached. The folder contained a .ogg and a text file. The .ogg played correctly, the text file was readable with correct contents.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/