[Kde-pim] Review Request: Enable direct attaching of folders in kmail

[Martin Bednar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102501/
-----------------------------------------------------------

(Updated Sept. 8, 2011, 11:47 a.m.)


Review request for KDEPIM.


Changes
-------

Modified to conform to coding style (hope I caught everything), renamed to attachmentfromfolderjob, addEntity now takes const refs as arguments, mZip is a QScopedPointer. 
Laurent : I don't see very well how to merge attachmentfromfolderjob and attachmentfromurljob. I'm thinking catching the mimetype the url points to in the doStart function and then doing what the new class does. Is this what you had in mind?


Summary
-------

Creates a new class attachmentfromfolder that enables automatic compression (zip) and attachment of folders dropped on the messagecomposer window.


This addresses bug 42767.
    http://bugs.kde.org/show_bug.cgi?id=42767


Diffs (updated)
-----

  messagecomposer/attachmentcontrollerbase.cpp f8aea5c 
  messagecore/CMakeLists.txt 821625f 
  messagecore/attachmentfromfolderjob.h PRE-CREATION 
  messagecore/attachmentfromfolderjob.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102501/diff


Testing
-------

Sent myself an email with a dropped folder attached. The folder contained a .ogg and a text file. The .ogg played correctly, the text file was readable with correct contents.


Thanks,

Martin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/