[Kde-pim] Review Request: Enable direct attaching of folders in kmail

[Martin Bednar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102501/
-----------------------------------------------------------

(Updated Sept. 8, 2011, 4:57 p.m.)


Review request for KDEPIM.


Changes
-------

Created a base class for attachmentfromurl and attachmentfromfolder. Please do comment, this is completely new to me and was full of improvisation.


Summary
-------

Creates a new class attachmentfromfolder that enables automatic compression (zip) and attachment of folders dropped on the messagecomposer window.


This addresses bug 42767.
    http://bugs.kde.org/show_bug.cgi?id=42767


Diffs (updated)
-----

  messagecomposer/attachmentcontrollerbase.cpp f8aea5c 
  messagecore/CMakeLists.txt 821625f 
  messagecore/attachmentfromfolderjob.h PRE-CREATION 
  messagecore/attachmentfromfolderjob.cpp PRE-CREATION 
  messagecore/attachmentfromurlbasejob.h PRE-CREATION 
  messagecore/attachmentfromurlbasejob.cpp PRE-CREATION 
  messagecore/attachmentfromurljob.h c509114 
  messagecore/attachmentfromurljob.cpp 615218a 

Diff: http://git.reviewboard.kde.org/r/102501/diff


Testing
-------

Sent myself an email with a dropped folder attached. The folder contained a .ogg and a text file. The .ogg played correctly, the text file was readable with correct contents.


Thanks,

Martin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/