[Kde-pim] Review Request: Enable direct attaching of folders in kmail

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102501/#review6333
-----------------------------------------------------------


Now a real merge.
This two class has the same function:
    /**
     * Sets the @p url that will be loaded as attachment.
     */
    void setUrl( const KUrl &url );

    /**
     * Returns the url that will be loaded as attachment.
     */
    KUrl url() const;

    /**
     * Sets the maximum @p size the attachment is allowed to have.
     */
    void setMaximumAllowedSize( qint64 size );

    /**
     * Returns the maximum size the attachment is allowed to have.
     */
    qint64 maximumAllowedSize() const;

  protected Q_SLOTS:
    virtual void doStart();


Some create a base class with theses functions
and create subclass
AttachmentFromUrlJob and AttachmentFromFolderJob which herited from this base class
So we reduce duplicate code.

less code and more readable.
I prefere it.


- Laurent


On Sept. 8, 2011, 11:47 a.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102501/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 11:47 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Creates a new class attachmentfromfolder that enables automatic compression (zip) and attachment of folders dropped on the messagecomposer window.
> 
> 
> This addresses bug 42767.
>     http://bugs.kde.org/show_bug.cgi?id=42767
> 
> 
> Diffs
> -----
> 
>   messagecomposer/attachmentcontrollerbase.cpp f8aea5c 
>   messagecore/CMakeLists.txt 821625f 
>   messagecore/attachmentfromfolderjob.h PRE-CREATION 
>   messagecore/attachmentfromfolderjob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102501/diff
> 
> 
> Testing
> -------
> 
> Sent myself an email with a dropped folder attached. The folder contained a .ogg and a text file. The .ogg played correctly, the text file was readable with correct contents.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/