[Kde-pim] Review Request: properly honor resource when applying filters to new emails

[Milian Wolff]

> On Aug. 29, 2011, 8:27 p.m., Ingo Klöcker wrote:
> > Looks reasonable, but I'm not entirely sure whether this also works for POP3 accounts. Is the resource of a message downloaded via POP3 the corresponding POP3 resource? Or has the message already been assigned to the corresponding "inbox" folder of some local mail resource (maildir/mbox/mixedmail) before the filtering starts?
> > 
> > The signature of process() is basically the same as before Akonadi. Only the types of the arguments have changed. This kind of explains its weirdness.
> 
> Milian Wolff wrote:
>     I have a pop3 resource but that somehow downloads directly into a local mail resource. I.e. I have:
>     
>     "mail at milianw.de" / akonadi_pop3_resource_0 which downloads its mails to "KMail Folders" / akonadi_mixedmaildir_resource_1
>     
>     Don't ask me where the latter comes from. But yeah, the filtering starts only after the mail is in the inbox of the latter resource. Anyways, it works like a charm there and for my imap accounts. Is your question answered?
>     
>     @func signature: I'll rewrite the diff then and cleanup the signature while I'm at it.
>     
>     bye
> 
> Ingo Klöcker wrote:
>     So associating a filter to a POP3 resource doesn't work? Of course, that's not a problem of your patch. I was just wondering.

No, there is nothing special about POP3. Right now (without the patch above) the "from checked accounts only" filter setting has no effect at all, it is applied to all resources (be it POP3, IMAP, ...). My patch is solving this issue.

I'll push it later today.

bye


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102446/#review6148
-----------------------------------------------------------


On Aug. 26, 2011, 7:04 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102446/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 7:04 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> This is most probably just a dirty "get it working" patch, but I want to post it here for review. First the problem it solves:
> 
> When starting kmail, it will apply all filters to all new emails without honoring the "apply this filter to incoming messages: from checked accounts only" setting.
> 
> The easiest way to notice is by having a "spamc" or spamassassin (or similar) filter that takes a long time and have that apply to only a very specific account. Then, when a different account gets new email you should see a load spike / spamc processes even though there should be none.
> 
> Imo the whole design of FilterManager::process's function signature is pretty bad. Shouldn't/couldn't the optional stuff be removed and item.parentCollection().resource() be used instead?
> 
> 
> Diffs
> -----
> 
>   mailcommon/filtermanager.cpp 7d0372e 
> 
> Diff: http://git.reviewboard.kde.org/r/102446/diff
> 
> 
> Testing
> -------
> 
> ran kmail2 for ~1 day. it finally worked like it should
> 
> 
> Thanks,
> 
> Milian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/