[Kde-pim] Review Request: kmail: now it is allowed to create a new folder on the top of an imap folder

Andras Mantia amantia at kde.org
Wed Sep 21 12:58:41 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102031/#review6691
-----------------------------------------------------------



resources/imap/retrievecollectionstask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment5918>

    I'm not sure of these changes, as I heard there are some imap servers that do not support creating toplevel folders. Also on IMAP servers there can be folders (collection) that disallow subfolder creation.
    Before this is committed, it needs to be checked that the code works fine in those cases.


- Andras


On Sept. 20, 2011, 3:37 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102031/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 3:37 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> On kmail 2, if you try to add a folder under your top imap folder, you will see that the button "Add folder" is disable. This patch is fixing this issue.
> 
> 
> This addresses bug 251704.
>     http://bugs.kde.org/show_bug.cgi?id=251704
> 
> 
> Diffs
> -----
> 
>   resources/imap/addcollectiontask.h de83683 
>   resources/imap/addcollectiontask.cpp 81c7dd9 
>   resources/imap/retrievecollectionstask.cpp e86a2ba 
> 
> Diff: http://git.reviewboard.kde.org/r/102031/diff
> 
> 
> Testing
> -------
> 
> Kdepim and kdepim-runtime compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list