[Kde-pim] Review Request: avoid the use of an undefined collection

[Guy Maurel]

Hello Kevin!

On Sunday, October 09, 2011 06:16:42 PM Kevin Krammer wrote:
> Hi Guy,

> I looked at it before doing my research (see my other mail from today).
> As far as I can tell it is making the job result in success without setting 
> the resource roo/toplevel collection.
I found another part of code, which is still a mystery for me, I'll explain:
  kdepimlibs/akonadi/specialcollectionshelperjobs.cpp
at the method:
  DefaultResourceJobPrivate::tryFetchResource()

at line 265:
    CollectionFetchJob *fetchJob = new CollectionFetchJob( Collection::root(), CollectionFetchJob::Recursive, q );
    fetchJob->fetchScope().setResource( resourceId );
    fetchJob->fetchScope().setIncludeStatistics( true );
    q->connect( fetchJob, SIGNAL(result(KJob*)), q, SLOT(collectionFetchResult(KJob*)) );

the variable "fetchJob" is declared and get a new value, but after the "connect" I find only the end of the method.
Doesn't it need any "start" job?
How does it works?
-- 
guy
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/