[Kde-pim] Review Request: avoid the use of an undefined collection

[Kevin Krammer]

Hi Guy,

On Sunday, 2011-10-09, Guy Maurel wrote:
> Hello Kevin (and other)!
> 
> I have a new proposal, a little bit more complicated, but I think, working
> pretty well.
> I'll like to get your comments.
> https://git.reviewboard.kde.org/r/102765/
> written on 5th october

I looked at it before doing my research (see my other mail from today).
As far as I can tell it is making the job result in success without setting 
the resource roo/toplevel collection.

Doesn't this result in an assert in 
SpecialCollectionsRequestJobPrivate::createRequestedFolders or errors when 
this method runs the CollectionCreateJobs?

I.e. isn't the collection returned by scanJob->rootResourceCollection() 
invalid?

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20111009/c5e1d479/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/