[Kde-pim] Review Request: Hook ICalTimeZones to Incidence Writers

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102838/
-----------------------------------------------------------

(Updated Oct. 28, 2011, 1:36 a.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Now writing standard timezones too.


Description
-------

iCal Timezone information was being dropped because incidence writers were not able to communicate what timezones had been used in the incidences. This patch hooks timezone lists to the calls to incidence writers and prints the list of timezones used.


This addresses bug 68345.
    http://bugs.kde.org/show_bug.cgi?id=68345


Diffs (updated)
-----

  kcalcore/icalformat.cpp 105efc5 
  kcalcore/icalformat_p.h ec63586 
  kcalcore/icalformat_p.cpp 5938d02 

Diff: http://git.reviewboard.kde.org/r/102838/diff/diff


Testing
-------

1. Use an iCal event that defines a "custom" timezone (see, e.g. https://bugs.kde.org/attachment.cgi?id=63679)
2. Load it into KOrganizer/Akonadi or serialize it through code

This patch passes all KCalCore test cases.


Thanks,

David Narváez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/