[Kde-pim] Review Request: Hook ICalTimeZones to Incidence Writers

[David Narváez]

> On Oct. 28, 2011, 12:52 a.m., Sergio Luis Martins wrote:
> > kcalcore/icalformat.cpp, line 324
> > <http://git.reviewboard.kde.org/r/102838/diff/2/?file=39458#file39458line324>
> >
> >     You won't need it.

Negative, the code checks for tzList before writing to tzUsedList.

https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/d911993eb99270cca618050b356d64e1ca06b079/entry/kcalcore/icalformat_p.cpp#L2300


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102838/#review7704
-----------------------------------------------------------


On Oct. 23, 2011, 3:53 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102838/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 3:53 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> iCal Timezone information was being dropped because incidence writers were not able to communicate what timezones had been used in the incidences. This patch hooks timezone lists to the calls to incidence writers and prints the list of timezones used.
> 
> 
> This addresses bug 68345.
>     http://bugs.kde.org/show_bug.cgi?id=68345
> 
> 
> Diffs
> -----
> 
>   kcalcore/icalformat.cpp 105efc5 
>   kcalcore/icalformat_p.h ec63586 
>   kcalcore/icalformat_p.cpp 5938d02 
> 
> Diff: http://git.reviewboard.kde.org/r/102838/diff/diff
> 
> 
> Testing
> -------
> 
> 1. Use an iCal event that defines a "custom" timezone (see, e.g. https://bugs.kde.org/attachment.cgi?id=63679)
> 2. Load it into KOrganizer/Akonadi or serialize it through code
> 
> This patch passes all KCalCore test cases.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/