[Kde-pim] Review Request: fix background color in month calendar view

Jeremy Paul Whiting jpwhiting at kde.org
Sat Nov 19 01:15:26 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103181/
-----------------------------------------------------------

(Updated Nov. 19, 2011, 1:15 a.m.)


Review request for KDEPIM.


Changes
-------

Actually, using Base instead of Window matches better imo.  It also makes it use white in the default color scheme, like it used to be hard coded to.


Description
-------

Background colors should not be hard coded if the foreground color is coming from the color scheme.  To see the problem simply change your color scheme to "Wonton Dark" and notice you can't easily read the light blue month name and day names against the white background.  This patch fixes the background to come from the color scheme.


Diffs (updated)
-----

  calendarviews/eventviews/month/monthscene.cpp 0f60350 

Diff: http://git.reviewboard.kde.org/r/103181/diff/diff


Testing
-------

Manual testing looks fine here.


Thanks,

Jeremy Paul Whiting

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list