[Kde-pim] Review Request: fix background color in month calendar view

Jeremy Paul Whiting jpwhiting at kde.org
Fri Nov 18 20:14:11 GMT 2011



> On Nov. 18, 2011, 8:07 p.m., Sergio Luis Martins wrote:
> > Looks ugly with the default scheme now. Maybe hardcoding the foreground to black would be a better option.

With "default" color scheme now here it looks fine, black text on an off-white background.  Could you give a screenshot of what you are seeing?  At any rate, hard coding it at all is the wrong answer...


- Jeremy Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103181/#review8302
-----------------------------------------------------------


On Nov. 18, 2011, 3:17 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103181/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 3:17 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Background colors should not be hard coded if the foreground color is coming from the color scheme.  To see the problem simply change your color scheme to "Wonton Dark" and notice you can't easily read the light blue month name and day names against the white background.  This patch fixes the background to come from the color scheme.
> 
> 
> Diffs
> -----
> 
>   calendarviews/eventviews/month/monthscene.cpp 0f60350 
> 
> Diff: http://git.reviewboard.kde.org/r/103181/diff/diff
> 
> 
> Testing
> -------
> 
> Manual testing looks fine here.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list