[Kde-pim] Re: Review Request: Make it possible to CollectionFilterProxyModel reject virtual collections.

[Sergio Luis Martins]

> On May 1, 2011, 10:06 a.m., Stephen Kelly wrote:
> > The patch looks harmless.
> > 
> > Some thoughts:
> > 
> > * I thought that class was obsoleted by recursivecollectionfilterproxymodel. If the source model data changes (probably unlikely in the case of collection mimetypes) or structure changes (if a collection is moved for example) that class won't handle it correctly.
> > * That class uses a QVector<QModelIndex> which should probably be using QPersistentModelIndex instead, but I didn't read the code closely.
> > * We really need to revisit that virtual collection stuff. For reasons I don't remember, but were documented on the wiki somewhere about 2 years ago, we probably need to make virtual resources part of the API and concepts, not virtual collections.

Mark it as deprecated and I'll port korg's code to use RCFPM for 4.7

Other users are:
kdepim/libkdepim/completionordereditor.cpp
kdepim/kjots/plasmoid/akonotes_noteslistapplet.cpp


- Sergio Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101259/#review3001
-----------------------------------------------------------


On April 30, 2011, 4:32 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101259/
> -----------------------------------------------------------
> 
> (Updated April 30, 2011, 4:32 p.m.)
> 
> 
> Review request for KDEPIM and KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> Make it possible to CollectionFilterProxyModel reject virtual collections.
> 
> 
> Diffs
> -----
> 
>   akonadi/collectionfilterproxymodel.h 259b105 
>   akonadi/collectionfilterproxymodel.cpp bcf33b3 
> 
> Diff: http://git.reviewboard.kde.org/r/101259/diff
> 
> 
> Testing
> -------
> 
> Tested in korg resource view.
> 
> 
> Thanks,
> 
> Sergio Luis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/