[Kde-pim] Re: new Note class, a KMime::Message::Ptr wrapper

[Christian Mollekopf]

On Sun, 08 May 2011 15:42:45 +0200, Stephen Kelly <steveire at gmail.com>  
wrote:

> Christian Mollekopf wrote:
>>
>> For now I think we just need the message function and the mimetype and
>> icon name available.
>> This would allow for deduplication in kjots, my app (MindMirror, ex.
>> notetaker) and the notefeeder I am working on.
>>
>> So, to keep the Note class available for the above version, I would
>> suggest to put this code as NoteMessageWrapper into
>> kdepimlibs/akonadi/notes/noteutils.h,
>> the namespace and icon name could go as free functions into the  
>> NoteUtils
>> namespace.
>>
>> Would that be ok?
>
> I'm fine with the mimetype and icon name as free functions in a NoteUtils
> namespace, yes.
>
> The current class implementation doesn't have the usual BiC protections  
> (the
> d pointer stuff), but if only the message method is needed maybe that  
> can be
> a free function as well? Maybe even rename it createMessage.

We could do it also this way, but we would also need the decodeMessage  
function.
Also I'm not a big fan of functions with 5 arguments, so I would rather  
keep it as a class.
I can add the d pointer of course.

I have no strong opinion about it though, so it's your call.

Cheers


>
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/


-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/