[Kde-pim] Re: new Note class, a KMime::Message::Ptr wrapper

[Stephen Kelly]

Christian Mollekopf wrote:

> On Tue, 10 May 2011 23:52:16 +0200, Christian Mollekopf
> <chrigi_1 at fastmail.fm> wrote:
> 
>> On Sun, 08 May 2011 15:42:45 +0200, Stephen Kelly <steveire at gmail.com>
>> wrote:
>>
>>> Christian Mollekopf wrote:
>>>>
>>>> For now I think we just need the message function and the mimetype and
>>>> icon name available.
>>>> This would allow for deduplication in kjots, my app (MindMirror, ex.
>>>> notetaker) and the notefeeder I am working on.
>>>>
>>>> So, to keep the Note class available for the above version, I would
>>>> suggest to put this code as NoteMessageWrapper into
>>>> kdepimlibs/akonadi/notes/noteutils.h,
>>>> the namespace and icon name could go as free functions into the
>>>> NoteUtils
>>>> namespace.
>>>>
>>>> Would that be ok?
>>>
>>> I'm fine with the mimetype and icon name as free functions in a
>>> NoteUtils
>>> namespace, yes.
>>>
>>> The current class implementation doesn't have the usual BiC protections
>>> (the
>>> d pointer stuff), but if only the message method is needed maybe that
>>> can be
>>> a free function as well? Maybe even rename it createMessage.
>>
> 
> Also I just added a function to get the plainText version of the content
> using QTextDocument (not sure if this is the best way).
> 

Do you have an updated version of this class to review?

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/