[Kde-pim] Re: Review Request: Small fixes to KMime and KIMAP tests

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100962/#review2262
-----------------------------------------------------------

Ship it!


I can't really judge the kmime parts of the patch, but the kimap parts are ok with me.

- Kevin


On March 28, 2011, 9:47 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100962/
> -----------------------------------------------------------
> 
> (Updated March 28, 2011, 9:47 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This is fixes 4 small issues on KMime and KIMAP tests:
> 
> 1. Remove the dependency on KIO for the KIMAP executable tests. KIO::SslUi was needed by testimapidle.cpp and testimapserver.cpp to display a dialog box asking to ignore SSL errors. Since those are only tests, I suggest always ignoring SSL errors. This makes building the tests much easier.
> 
> 2. Use QCoreApplication instead of QApplication in TestImapIdle and TestImapServer
> 
> 3. Remove a useless dependency on KDEUI in KMime tests.
> 
> 4. Fix a bug in KMime::headerTest: MSVC was deleting the intermediate value, causing the data pointer to be invalid
> 
> 
> Diffs
> -----
> 
>   kimap/tests/CMakeLists.txt 077c3e2 
>   kimap/tests/testimapidle.cpp 67afb04 
>   kimap/tests/testimapserver.cpp 9220d7a 
>   kmime/tests/auto/CMakeLists.txt f5ae49f 
>   kmime/tests/auto/headertest.cpp 1a27ed9 
> 
> Diff: http://git.reviewboard.kde.org/r/100962/diff
> 
> 
> Testing
> -------
> 
> Tested on Windows with MSVC 2008.
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/