[Kde-pim] Review Request: Small fixes to KMime and KIMAP tests

Gregory Schlomoff gregory.schlomoff at gmail.com
Mon Mar 28 10:47:34 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100962/
-----------------------------------------------------------

Review request for KDEPIM-Libraries and Kevin Ottens.


Summary
-------

This is fixes 4 small issues on KMime and KIMAP tests:

1. Remove the dependency on KIO for the KIMAP executable tests. KIO::SslUi was needed by testimapidle.cpp and testimapserver.cpp to display a dialog box asking to ignore SSL errors. Since those are only tests, I suggest always ignoring SSL errors. This makes building the tests much easier.

2. Use QCoreApplication instead of QApplication in TestImapIdle and TestImapServer

3. Remove a useless dependency on KDEUI in KMime tests.

4. Fix a bug in KMime::headerTest: MSVC was deleting the intermediate value, causing the data pointer to be invalid


Diffs
-----

  kimap/tests/CMakeLists.txt 077c3e2 
  kimap/tests/testimapidle.cpp 67afb04 
  kimap/tests/testimapserver.cpp 9220d7a 
  kmime/tests/auto/CMakeLists.txt f5ae49f 
  kmime/tests/auto/headertest.cpp 1a27ed9 

Diff: http://git.reviewboard.kde.org/r/100962/diff


Testing
-------

Tested on Windows with MSVC 2008.


Thanks,

Gregory

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list