[Kde-pim] Re: Fwd: [PATCH] Changing ownertrust with Kleopatra

[Marc Mutz]

Hi Allen, Dominik,

On Sunday May 29 2011, you wrote:
> could be of interest to you, Marc

I've finally had a look at his, sorry for the delay.

I don't have a working master of kdepim, but in my last build (v2.1.0 against 
KDE 4.5.1), I cannot reproduce this bug report.

Looking at the diff between e4 and master, only
 03821ea6bab237aab6efbcf33d418020a58d7439
stands out.

Indeed, it changes the setupUi() call argument from q to q->mainWidget(). The 
latter, of course, doesn't contain the required slot.

Regarding Dominik's patch, I don't like the fact that signal/slot connections 
to the form in designer no longer work from ui files directly, when 
inheriting KDialog. I've used this in many, if not all, dialogs in Kleo and 
if the change to KDialog broke OwnerTrustDialog, it likely also broke other 
dialogs. I certainly don't want to maintain a "solution" where all the 
connections go from the ui file into the cpp file instead, in all dialogs, 
esp. since keeping connections in the ui file is what I preach in every 
training :)

I don't see a good solution here, KDialog certainly isn't made to work with UI 
files.

I guess a workable solution, then, is to have the ui file spit out a QWidget, 
which can be planted into KDialog, and that carries the slot.

Tobias, would you mind implementing the "workable solution" for all dialogs 
you converted from QDialog to KDialog in Kleo, please?

Thanks,
Marc

> ----------  Forwarded Message  ----------
>
> Subject: [Kde-pim]  [PATCH] Changing ownertrust with Kleopatra
> Date: Sunday 29 May 2011, 4:50:28 AM
> From: Dominik Cermak <d.cermak at arcor.de>
> To: kde-pim at kde.org
>
> Hi all,
>
> There is a bug in Kleopatra which prevents one from changing the
> ownertrust of a opengpg key: [1]. This report is for Kleopatra Mobile
> but Kleopatra on desktop is also affected.
>
> After looking into the sourcecode and some testing I recognized, that
> the slot slotTrustLevelChanged() is not called on changing the radio
> button. After looking in another dialog (selftestdialog) I took the
> connect() statements from ui_ownertrustdialog.h into
> ownertrustdialog.cpp and it solved the Problem for me.
>
> The patch is attached, don't know if it is the correct approach since I
> havn't any Qt/KDE-Coding experience yet.
>
> Greetings Dominik
>
> [1] https://bugs.kde.org/show_bug.cgi?id=267468
>
>
> -----------------------------------------



-- 
Marc Mutz <marc.mutz at kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/