[Kde-pim] Re: Review Request: speedup kmail.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101697/#review4571
-----------------------------------------------------------


This review has been submitted with commit 20561bbf3ce62c9d3516ca0dccf945ecb501c3f4 by Jaime Torres to branch master.

- Commit


On July 8, 2011, 3:35 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101697/
> -----------------------------------------------------------
> 
> (Updated July 8, 2011, 3:35 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> NOTE: The patch is incomplete. It lacks a signal handler, remove some comments....
> But I want to know if I'm using the right path, specially with the MessageItem fonts. Do I really need to store the fontKey for every item?
> Also, is this ABI and binary compatible?
> 
> In any case, as you could see in the attached screenshots, it makes the method cachedFontHeight go from 70% cpu usage to 5% (cachedFontHeightKey) just showing my kmail bugs folder (with around 40.000 mails).
> 
> 
> Diffs
> -----
> 
>   messagelist/core/themedelegate.cpp dad2847 
>   messagelist/core/themedelegate.h 90abcb8 
>   messagelist/core/theme.cpp bff6f86 
>   messagelist/core/theme.h 2ebf66f 
>   messagelist/core/messageitem_p.h cdf9ff1 
>   messagelist/core/messageitem.h 832e861 
>   messagelist/core/messageitem.cpp 6018fad 
> 
> Diff: http://git.reviewboard.kde.org/r/101697/diff
> 
> 
> Testing
> -------
> 
> Kmail feels faster. Callgrind says that QFont.key() usage is almost neligible after the patch is applied.
> 
> 
> Screenshots
> -----------
> 
> before the patch
>   http://git.reviewboard.kde.org/r/101697/s/184/
> after the patch
>   http://git.reviewboard.kde.org/r/101697/s/185/
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/