[Kde-pim] Re: Review Request: speedup kmail.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101697/#review4341
-----------------------------------------------------------


Sorry for the late reply, nice work :)
I think the general approach is sound, the font and geometry calculations have shown up during previous optimization attempts as well, esp. with themes with no uniform row height.

AFAICS you are not storing the font key for every item, which indeed would be a problem since this is also a major memory usage bottleneck for KMail. So, this looks fine as well.

You do not have to bother about ABI compatibility, this is not a public library yet.

- Volker


On June 19, 2011, 11:08 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101697/
> -----------------------------------------------------------
> 
> (Updated June 19, 2011, 11:08 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> NOTE: The patch is incomplete. It lacks a signal handler, remove some comments....
> But I want to know if I'm using the right path, specially with the MessageItem fonts. Do I really need to store the fontKey for every item?
> Also, is this ABI and binary compatible?
> 
> In any case, as you could see in the attached screenshots, it makes the method cachedFontHeight go from 70% cpu usage to 5% (cachedFontHeightKey) just showing my kmail bugs folder (with around 40.000 mails).
> 
> 
> Diffs
> -----
> 
>   messagelist/core/messageitem.h 832e861 
>   messagelist/core/messageitem.cpp 6018fad 
>   messagelist/core/messageitem_p.h cdf9ff1 
>   messagelist/core/theme.h 2ebf66f 
>   messagelist/core/theme.cpp bff6f86 
>   messagelist/core/themedelegate.h 90abcb8 
>   messagelist/core/themedelegate.cpp dad2847 
> 
> Diff: http://git.reviewboard.kde.org/r/101697/diff
> 
> 
> Testing
> -------
> 
> Kmail feels faster. Callgrind says that QFont.key() usage is almost neligible after the patch is applied.
> 
> 
> Screenshots
> -----------
> 
> before the patch
>   http://git.reviewboard.kde.org/r/101697/s/184/
> after the patch
>   http://git.reviewboard.kde.org/r/101697/s/185/
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/