[Kde-pim] Re: Review Request: fix assertion in monitoredItemMoved
Torgny Nyblom
kde at nyblom.org
Tue Jul 19 11:42:13 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101973/#review4848
-----------------------------------------------------------
Ship it!
Looking at the code for indexForCollection() it states that an index of -1 is an invalid index so this patch seems sane.
Not sure if the below comment changes anything since I could not find the code for that during the short time I looked.
akonadi/entitytreemodel_p.cpp
<http://git.reviewboard.kde.org/r/101973/#comment4210>
Might want to move the srcRow == -1 check to before the !q->..., since the later is then not called if the srcRow is an invalid index.
- Torgny
On July 16, 2011, 7:29 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101973/
> -----------------------------------------------------------
>
> (Updated July 16, 2011, 7:29 p.m.)
>
>
> Review request for KDEPIM-Libraries.
>
>
> Summary
> -------
>
> fixes an assertion in EntityTreeModelPrivate::monitoredItemMoved which I could reproduce everytime kmail2 was started in conjunction with the rest of my kde session. restarting kmail afterwards worked fine though.
>
> I have lots of filters, maybe it's related.
>
> The assertion was in m_childEntities[].takeAt() due to srcRow == -1 because indexOf apparently did not find the given itemId... No idea whats going on and whether it's bad but at least this way it's not crashing anymore.
>
>
> This addresses bug 250692.
> http://bugs.kde.org/show_bug.cgi?id=250692
>
>
> Diffs
> -----
>
> akonadi/entitytreemodel_p.cpp 33354bb
>
> Diff: http://git.reviewboard.kde.org/r/101973/diff
>
>
> Testing
> -------
>
> restarted KDE, no crash anymore.
>
>
> Thanks,
>
> Milian
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list