[Kde-pim] Re: Review Request: fix assertion in monitoredItemMoved

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101973/#review4868
-----------------------------------------------------------


Please do not ship this patch.
The patch does not fix the problem and is only a workaround.
Not sure yet what the actual problem is but a first guess is that it is related to the collectionFetchStrategy, but I would really need to know more about the state of the etm, to be able to debug this. Anyways there is ongoing work on the etm by skelly and me, so this might be fixed already.
If the workaround is really needed, put the check directly after const int srcRow = indexOf<Node::Item>( m_childEntities.value( sourceCollection.id() ), itemId ); (this must never fail), and state it clearly as workaround.

Cheers

- Christian


On July 16, 2011, 7:29 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101973/
> -----------------------------------------------------------
> 
> (Updated July 16, 2011, 7:29 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> fixes an assertion in EntityTreeModelPrivate::monitoredItemMoved which I could reproduce everytime kmail2 was started in conjunction with the rest of my kde session. restarting kmail afterwards worked fine though.
> 
> I have lots of filters, maybe it's related.
> 
> The assertion was in m_childEntities[].takeAt() due to srcRow == -1 because indexOf apparently did not find the given itemId... No idea whats going on and whether it's bad but at least this way it's not crashing anymore.
> 
> 
> This addresses bug 250692.
>     http://bugs.kde.org/show_bug.cgi?id=250692
> 
> 
> Diffs
> -----
> 
>   akonadi/entitytreemodel_p.cpp 33354bb 
> 
> Diff: http://git.reviewboard.kde.org/r/101973/diff
> 
> 
> Testing
> -------
> 
> restarted KDE, no crash anymore.
> 
> 
> Thanks,
> 
> Milian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/