[Kde-pim] Re: KCalCore ICalTimeZonesTest Failure

[David Jarvie]

On Tuesday 05 July 2011 19:20:27 Allen Winter wrote:
> Howdy,
> 
> This is probably for David Jarvie.
> Recently we've been getting this failure in the icaltimezones test.
> Fix please :)
> 
> -Allen
> 
> FAIL!  : ICalTimeZonesTest::offsetAtZoneTime() Compared values are not the same
>    Actual (offset2): -18000
>    Expected (-4*3600): -14400
>    Loc: [/data/kde/trunk/KDE/kdepimlibs/kcalcore/tests/testicaltimezones.cpp(341)]

It turns out that the test was wrong. I've fixed it in master and 4.7. If this test used to pass, it looks as if KTimeZone::offsetAtZoneTime() must have had a bug, which must have been fixed recently when I added caching to it.

-- 
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110706/2234f6ff/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/