[Kde-pim] Re: Review Request: Make collapse_thread and expand_thread actions work with group headers

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101832/#review4338
-----------------------------------------------------------


Does this actually work? I cannot move the current item on to a group header here, which seems to be the prerequisite for this patch to work.
Also, please don't use QModelIndex::internalPointer() outside of the model (will break once e.g. a proxy model is added or the model implementation changes), rather add a method similar to currentMessageItem() for this.

- Volker


On July 2, 2011, 5:33 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101832/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 5:33 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> This patch makes the actions that handle expanding and collapsing threads to handle group headers too, so groups can be opened and closed by using the menu or key shortcuts.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 0fb65ba 
>   messagelist/core/view.cpp 1163dc4 
> 
> Diff: http://git.reviewboard.kde.org/r/101832/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/