[Kde-pim] Review Request: Splitting of move to added/removed, fixed support for monitoring collections

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100534/
-----------------------------------------------------------

Review request for KDEPIM-Libraries, Tobias Koenig, Volker Krause, and Stephen Kelly.


Summary
-------

This is the splitcollectionmove_chris2.patch which does the following:

-Splitting of the move signal in added/removed signals.
-Proper support of monitoring collections (All subcollections of a monitored collection are now implicitly monitored, so signals are also emitted for those items/collections)
-some special cases are now handled properly, i.e. if a monitored collection is moved.

Improved version of the patch from skelly (supporting monitored collections properly).

Needs the patch from http://git.reviewboard.kde.org/r/100524/ to work.


Diffs
-----

  akonadi/monitor.h 33b8fa57409a4e5029cf1a7c46189a0ff24d9391 
  akonadi/monitor.cpp d433ab65c31eba215cbb3d6dea276a2cc7a14103 
  akonadi/monitor_p.h cc255c708c8daa0d606a83ea78424e9eba616b17 
  akonadi/monitor_p.cpp 745d0ec6e51342100dcfefb3d5b4e9f4578ccb87 

Diff: http://git.reviewboard.kde.org/r/100534/diff


Testing
-------

only manual testing, couldn't get the unittests to work so far.


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/