[Kde-pim] Review Request: Fix entitytreemodel so monitoring collections can be used

Christian Mollekopf chrigi_1 at fastmail.fm
Thu Feb 3 14:48:21 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100535/
-----------------------------------------------------------

Review request for KDEPIM and Stephen Kelly.


Summary
-------


-new function insertAndFetchCollection which helps streamlining the code a bit
-set m_rootCollection to collection::root also when a singled collection and a resource is monitored
-properly fetch all included collections
-fetch children of the root collection, if root is not shown and lazy population is active
-reset the model if the watched collection is moved

together with:
http://git.reviewboard.kde.org/r/100534/
http://git.reviewboard.kde.org/r/100524/

this fixes the entitytreemodel so it can be used with monitoring collections.


Diffs
-----

  akonadi/entitytreemodel.h 881593102feef69a73fefc6c26822efdf2a97966 
  akonadi/entitytreemodel_p.h 337174152a509b1c728633a3b79b684936021fc9 
  akonadi/entitytreemodel_p.cpp 122de35fc17fc99e698b451f7217a26f3518dd21 

Diff: http://git.reviewboard.kde.org/r/100535/diff


Testing
-------

tested it manually with all the combinations i could think of, and will continue to use it in my own app.


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list