[Kde-pim] Re: Review Request: Splitting of move to added/removed, fixed support for monitoring collections

[Stephen Kelly]

Christian Mollekopf wrote:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100534/
> -----------------------------------------------------------
> 
> Review request for KDEPIM-Libraries, Tobias Koenig, Volker Krause, 
and
> Stephen Kelly.
> 
> 
> Summary
> -------
> 
> This is the splitcollectionmove_chris2.patch which does the 
following:
> 
> -Splitting of the move signal in added/removed signals.

Here's a counter-proposal patch which only does this splitting part 
and depends on the akonadi server patch also just posted.

We can rebase the rest of your patch on top of this and update it. I 
prefer to keep patches as small and focussed on one thing as possible.

Thanks,

Steve.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move_split.patch
Type: text/x-patch
Size: 3134 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110204/e49c254e/attachment.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/