[Kde-pim] Source incompatible change :(

[David Faure]

On Friday 09 December 2011 22:29:46 Kevin Krammer wrote:
> On Friday, 2011-12-09, David Faure wrote:
> > On Friday 09 December 2011 19:00:34 =?ISO-8859-1?Q?S=E9rgio?= Martins 
wrote:
> > > Hi,
> > > 
> > > Commit  2eb3de21a61b4816770ae9bdd38b07d799b60337 in kdepimlibs seems to
> > > be ABI and source incompatible.

Actually, I don't think it is. I didn't have to recompile kmail after making 
the change. Unless the app code puts the StatisticsProxyModel * into a QSFPM 
*, the change doesn't break SC. And it doesn't break BC either, because the 
vtable is the same (QAIM virtual methods).

> > Aww, crap, why do we have ABI requirements for libs that are only used by
> > kdepim?
> 
> There is no way of telling if something is only used by kdepim if it is not
> in kdepim.
> In this particual case it is part of libakonadi-kde which is almost
> certainly used in other places.

This proxy is for showing unread mails in the folder tree. "Almost certainly" 
there are other mail clients based on libakonadi-kde?

> > So, should I revert and keep kmail slow for theoretical 3rd-party apps, or
> > is there a good reason for the BIC/SIC requirements?
> 
> Same as for kdelibs, i.e. part of the platform.
> We keep libs for which we don't want or can't keep strict compatibility
> requirements inside the same module as the app.

I wonder why StatisticsProxyModel is in kdepimlibs then, all its users are in 
kdepim. I think putting everything into a public lib "by default" is shooting 
ourselves in the foot, in the long run.

See, this is different in kdelibs, we only put there stuff that is used by 
multiple kde modules/apps.

In kdepimlibs, I have the feeling that everything akonadi-related was put into 
libakonadi-kde, just because it was easiest at the time, without realizing 
that this was going to make future changes harder.

-- 
David Faure | david.faure at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/