[Kde-pim] Review Request: (minor) correct C&P error in AgentBase::collectionChanged()

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103334/#review8837
-----------------------------------------------------------

Ship it!


You are right, this is a copy/paste mistake.

- Volker Krause


On Dec. 5, 2011, 11:29 a.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103334/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2011, 11:29 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Description
> -------
> 
> It looks like the code for the 2-argument version of collectionChanged() was copied and pasted from itemChanged and uses partIdentifiers for the second param, instead of changedAttributes. AFAIK collections have attributes and properties but not parts, and this error propagated into the nepomuk feeder, so I'm fixing it at source.
> 
> 
> Diffs
> -----
> 
>   akonadi/agentbase.cpp 7e36bd6 
>   akonadi/agentbase_p.h 34e3288 
> 
> Diff: http://git.reviewboard.kde.org/r/103334/diff/diff
> 
> 
> Testing
> -------
> 
> make clean && make
> 
> 
> Thanks,
> 
> Will Stephenson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/