[Kde-pim] Review Request: making kmail network-aware

[Martin Bednar]

> On Aug. 25, 2011, 8:40 p.m., Sergio Luis Martins wrote:
> > kmail/kmkernel.cpp, line 940
> > <http://git.reviewboard.kde.org/r/102431/diff/2/?file=32875#file32875line940>
> >
> >     Not knowing anything about the implementation of Status(), i would cache the result:
> >     
> >     const bool status = Solid::Networking::Status()

At the very least, I think it shouldn't be a const (the status can change while kmail is running). I'll go ask the Solid guys about the implementation... IMO adding another variable is useless, and could lead to confusion as to what is kmail-internal and what is system-wide.
Are the functions where Solid::Networking::Status() is called called often?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/#review6010
-----------------------------------------------------------


On Aug. 25, 2011, 12:46 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102431/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2011, 12:46 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Changes Solid calls to not render KMail useless when Solid can't detect network connection (same as Andreas did in isOffline). Asks the user to go online only based on the internal Kmail networkState status, ignoring the status of the network. Modifies behaviour of askToGoOnline() function to return false when there is no network detected, thus making checkMailOnStartup() and checkMail() functions network-aware.
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.cpp 091209e 
> 
> Diff: http://git.reviewboard.kde.org/r/102431/diff
> 
> 
> Testing
> -------
> 
> compiles,runs, works fine with solid not detecting network, haven't bumped into any issue with Solid working.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/