[Kde-pim] Review Request: making kmail network-aware

[Andras Mantia]

> On Aug. 25, 2011, 4:42 p.m., Martin Bednar wrote:
> > kmail/kmkernel.cpp, line 991
> > <http://git.reviewboard.kde.org/r/102431/diff/2/?file=32875#file32875line991>
> >
> >     Because isOffline now returns based on the system's network status, with which this dialog can't do anything. We only want this dialog to change KMail's internal online status. It is most visible when starting KMail without any network connection : this dialog pops up (regularly if periodic mail checking is enabled) and does absolutely nothing.

isOffline doesn't check the Solid status if the global network state is Offline:

  if ( ( GlobalSettings::self()->networkState() == GlobalSettings::EnumNetworkState::Offline ) ||
       ( Solid::Networking::status() == Solid::Networking::Unconnected ) || ( Solid::Networking::status() == Solid::Networking::Disconnecting ) )
    return true;

And yes, I have a setup where solid says i'm not in a connected state, and got no warning dialog on startup about being offline, so everything works fine (as expected).


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/#review6005
-----------------------------------------------------------


On Aug. 25, 2011, 12:46 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102431/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2011, 12:46 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Changes Solid calls to not render KMail useless when Solid can't detect network connection (same as Andreas did in isOffline). Asks the user to go online only based on the internal Kmail networkState status, ignoring the status of the network. Modifies behaviour of askToGoOnline() function to return false when there is no network detected, thus making checkMailOnStartup() and checkMail() functions network-aware.
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.cpp 091209e 
> 
> Diff: http://git.reviewboard.kde.org/r/102431/diff
> 
> 
> Testing
> -------
> 
> compiles,runs, works fine with solid not detecting network, haven't bumped into any issue with Solid working.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/