[Kde-pim] Re: Review Request: Wait for KSycoca to become available before accessing it

[Volker Krause]

On Thursday 28 April 2011 10:48:18 Andre Heinecke wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101248/
> -----------------------------------------------------------
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> When starting Kontact for the first time on a system where no KDE is running
> there is a race between Kded to create a KSycoca database and Kontact to
> access the KSycoca database. In those cases Kontact starts without plugins
> and looks like the attached screenshot. On most GNU/Linux systems this code
> will never be reached but on Windows this happened reliably at the first
> startup for each new User starting Kontact.
> 
> Testing on a 2,8 GHz dual core System showed that a two second sleep of
> Kontact is enough. So the 10 second wait timeout should suffice on most
> systems. The added Messagebox in case the timeout is reached can be helpful
> to distributors or users with a broken setup.
> 
> 
> This addresses bug 269807.
>     http://bugs.kde.org/show_bug.cgi?id=269807

While this looks like a correct diagnosis of the problem and a working fix to 
me, this is also extremely ugly and IMHO also the wrong place to fix it, this 
probably affects way more applications than just Kontact. David, what would be 
a better place for this? Is there maybe code for this already, since this 
seems to work fine on Linux?

> Diffs
> -----
> 
>   kontact/src/mainwindow.h 24c6f29
>   kontact/src/mainwindow.cpp 1f1775e
> 
> Diff: http://git.reviewboard.kde.org/r/101248/diff
> 
> 
> Testing
> -------
> 
> Tested on Windows and GNU/Linux although i was unable to reproduce the
> problem on Linux in the first place.
> 
> 
> Screenshots
> -----------
> 
> Kontact without sycoca
>   http://git.reviewboard.kde.org/r/101248/s/140/

regards
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110430/ba546ead/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/