[Kde-pim] Re: Review Request: ktimetracker - editing desktop list on a not-new task doesn't work

[Cristi Posoiu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100952/
-----------------------------------------------------------

(Updated April 3, 2011, 8:42 a.m.)


Review request for KDEPIM.


Changes
-------

well, my first patch was fixing the problem of desktop list not being updated when auto-tracking was still set to true.
Anyway - here's an updated patch that should fix the bug you mentioned too, and even a little more (see the ->clear() call)


Summary
-------

it seems you can't *change* the desktops you're tracking the task on.
Problem being the list of currently checked desktops is not retreived so that the task is updated.


Diffs (updated)
-----

  ktimetracker/edittaskdialog.cpp 103c95c 
  ktimetracker/taskview.cpp 55bc975 

Diff: http://git.reviewboard.kde.org/r/100952/diff


Testing
-------

- create task; add it 
- edit the task again
- change desktops settings (set auto-tracking = true)
- press ok
- edit again the task
-- you'll see your changes re: desktops are not there


Thanks,

Cristi

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/