[Kde-pim] Re: Review Request: Kmail: check fcc collection in the MDA.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100829/#review2439
-----------------------------------------------------------


Thanks for the patch, I have just comitted it, see http://commits.kde.org/kdepim-runtime/a074f5ed435de191abd420230f04912e8dca75f6.

I have changed a few things before comotting:
- Correctly assign mCurrentJob so that the parent job can correctly be aborted
- Set the job to an error state when hasDefaultCollection() return false
- also check for hasDefaultCollection() in the result slot
- added a few more uses of the "const" keyword

- Thomas


On April 6, 2011, 3:21 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100829/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 3:21 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This patch is fixing a hole in the MDA. If the fcc folder is deleted when the message is queued, then the mail is lost. With my patch the mail is saving in the default sent-mail collection. I forgot to check for the whitespace... So i update my diff. Sorry for the trouble.
> 
> 
> Diffs
> -----
> 
>   agents/maildispatcher/sendjob.h 8f0cdc8 
>   agents/maildispatcher/sendjob.cpp 8e1fcc1 
> 
> Diff: http://git.reviewboard.kde.org/r/100829/diff
> 
> 
> Testing
> -------
> 
> Kdepim-runtime and kdepim is compiling without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/