[Kde-pim] Re: Review Request: Add more checks in Akonadi::ItemSync::updateItem

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100994/#review2292
-----------------------------------------------------------

Ship it!


Looks good, thanks!

- Volker


On March 31, 2011, 8:23 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100994/
> -----------------------------------------------------------
> 
> (Updated March 31, 2011, 8:23 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> This patch address an issue met with the DAV resource, but possibly others, that the item payload was not cleared correctly if Akonadi::Item::clearPayload() is called on an item submitted to Akonadi::ResourceBase::itemsRetrieved(). Now the mClearPayload boolean is checked, which requires to add Akonadi::ItemSync as a friend of Akonadi::Item. Another check is to compare both items remote revisions.
> 
> This patch is developed against master but must be backported to 4.6. Having discussed of this with Volker on IRC he assured me this is BC.
> 
> 
> Diffs
> -----
> 
>   akonadi/item.h f61a5cb 
>   akonadi/itemsync.cpp 5bb9db1 
> 
> Diff: http://git.reviewboard.kde.org/r/100994/diff
> 
> 
> Testing
> -------
> 
> Tested with the DAV resource, now the payload is correctly cleared.
> 
> 
> Thanks,
> 
> Grégory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/